feat(behavior): add select event
#644
Merged
+115
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christianhg
force-pushed
the
feat-behavior-select-event
branch
from
ab3366f to
8509fc9
Compare
christianhg
force-pushed
the
feat-behavior-select-event
branch
from
8509fc9 to
d1ff515
Compare
The `select` event is the first behavior event added that risks being triggered during behavior actions. For example, `decorator.toggle` triggers a bunch of internal Slate APIs under the hood, including `Transforms.select` which in turn calls `editor.select`. This recursive behavior, however, does not play well. Therefore, we now set a new `IS_APPLYING_BEHAVIOR_ACTIONS` flag that we check before sending a `select` behehavior event. If we are in the middle of applying behavior actions, we just call the default `select` method.
christianhg
force-pushed
the
feat-behavior-select-event
branch
from
d1ff515 to
22988b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.