Use Accelerate framework for texture image processing on iOS and fix premultiplication issues #6470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
force-pushed
the
ios-vimage
branch
from
37aefc4 to
4731f8c
Compare
|
Nice one finding this. Let's get it in and see how it goes. As touched on in discord, premult should still be our end-goal, but it can be put on the backburner as it's more of an optimisation than a must-have. |
peppy
approved these changes
Dec 23, 2024
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple offers high-performance / SIMD-based image processing API under its Accelerate framework called
vImage, suiting our needs perfectly as well as providing support for non-premultiplied image loading (I've only been aware of this as I was working towards changing the entire game to use premultiplied colours).The benchmark methodology may be basic, but I've benchmarked this by measuring time spent on loading each texture while randomly browsing through osu!. Results show roughly close match between master and this PR.
To ensure the premultiplication issues are appropriately fixed, I've added a test scene for it.
The intro artifacts in ppy/osu#9922 will not be fixed by this PR. A separate PR will handle this (ppy/osu-resources#351).