Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "debug printf" for headerTop value #847

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Oct 23, 2024

Commit 38f17af endeavored to "Improve watcher for scroll issues", and appears to have succeeded in that goal.

But it also added a "debug printf"-style console.log call for the value of headerTop, whenever that watcher is run. Which means that Furo-powered sites all over the Internet are constantly spewing (almost exclusively) headerTop: 0 onto the console, as users browse their pages.

@pradyunsg
Copy link
Owner

🤦🏽

@pradyunsg
Copy link
Owner

Thanks @ferdnyc!

@pradyunsg pradyunsg merged commit 3a225df into pradyunsg:main Jan 1, 2025
2 checks passed
@ferdnyc ferdnyc deleted the no-headerTop-logging branch January 1, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants