Rubicon Bid Adapter : ensure all query parameters follow camelCase convention #12612
Conversation
…nverted to camelCase.
|
@nassimlounadi do you work at Magnite? Would this change break existing users? |
|
Hey @nassimlounadi Not sure there really is a "standard" for bidder params in prebid. I understand the idea to do so but we have a lot of users already using the other way so I do not think this is a change our company would want to make. Maybe in a future major release - though I doubt it. |
|
@robertrmartinez would you be open to supporting either specification? |
| @@ -1107,7 +1107,7 @@ export function classifiedAsVideo(bidRequest) { | |||
| // based on whether or not there is a video object defined in the params | |||
| // Given this legacy implementation, other code depends on params.video being defined | |||
|
|
|||
| // if it's bidonmultiformat, we don't care of the video object | |||
| // if it's bidOnMultiFormat, we don't care of the video object | |||
There was a problem hiding this comment.
Interesting the param below this line was already camel case, possible bug @robertrmartinez ?
There was a problem hiding this comment.
nah its a locally declared variable so its fine
let isBidOnMultiformat = typeof deepAccess(bidRequest, `params.bidonmultiformat`) !== 'undefined';| @@ -214,7 +214,7 @@ export const converter = ortbConverter({ | |||
| bidRequest.params.position === 'btf' && imp.video && (imp.video.pos = 3); | |||
| delete imp.ext?.prebid?.storedrequest; | |||
|
|
|||
| if (bidRequest.params.bidonmultiformat === true && bidRequestType.length > 1) { | |||
| if (bidRequest.params.bidOnMultiFormat === true && bidRequestType.length > 1) { | |||
There was a problem hiding this comment.
You'll need to change this to handle both expressions to not break other people
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Switching
bidonmultiformattobidOnMultiFormatto adhere to the camelCase convention.