Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge text1 and text2 and put const/ewram data in C file #280

Merged
merged 8 commits into from
Dec 1, 2024
Merged

Merge text1 and text2 and put const/ewram data in C file #280

merged 8 commits into from
Dec 1, 2024

Conversation

DizzyEggg
Copy link
Contributor

No description provided.

SethBarberee
SethBarberee requested changes Nov 30, 2024
View reviewed changes
src/text.c Outdated Show resolved Hide resolved
src/code_801EE10.c Show resolved Hide resolved
src/code_8015080.c Show resolved Hide resolved
SethBarberee
SethBarberee requested changes Nov 30, 2024
View reviewed changes
src/code_801B3C0.c Show resolved Hide resolved
src/code_801B60C.c Show resolved Hide resolved
src/code_801C8C4.c Show resolved Hide resolved
src/code_801D014.c Show resolved Hide resolved
src/code_801D9E4.c Show resolved Hide resolved
src/code_801F808.c Show resolved Hide resolved
src/code_80227B8.c Show resolved Hide resolved
src/code_8023144.c Show resolved Hide resolved
src/code_8024458.c Show resolved Hide resolved
src/code_8272724.c Show resolved Hide resolved
@DizzyEggg
Copy link
Contributor Author

All should be covered.

SethBarberee
SethBarberee requested changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@SethBarberee SethBarberee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed some extra includes in src/code_801B60C.c, src/code_801D9E4.c, and src/code_8024458.c

@DizzyEggg
Copy link
Contributor Author

Missed some extra includes in src/code_801B60C.c, src/code_801D9E4.c, and src/code_8024458.c

Done

@SethBarberee SethBarberee merged commit 0d27fb2 into pret:master Dec 1, 2024
1 check passed
@DizzyEggg DizzyEggg deleted the text1 branch December 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethBarberee SethBarberee SethBarberee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DizzyEggg @SethBarberee