Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GMM headers for pl_msg at build-time #119

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

lhearachel
Copy link
Collaborator

No description provided.

Copy link
Member

@mid-kid mid-kid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change expects that the build dir is always directly one level under the source directory. I think there's ways to get a full path to the source directory in meson, but putting build artifacts in the source directory is really bad practice.

Please explore the possibility for generating these files in the build directory, and adding the include path to the compiler include path (through its command line) instead. See https://mesonbuild.com/Include-directories.html#include-directories

res/text/meson.build Outdated Show resolved Hide resolved
@lhearachel
Copy link
Collaborator Author

Please explore the possibility for generating these files in the build directory, and adding the include path to the compiler include path (through its command line) instead.

I got this working, with the added caveat that it requires res to be walked before src, but that's not a huge deal, IMO.

@mid-kid
Copy link
Member

mid-kid commented Dec 22, 2023

Thanks! It looks nice now.

@lhearachel lhearachel force-pushed the pl_msg_build_refactor branch from 5ea624f to 1f277a9 Compare December 22, 2023 23:31
@lhearachel
Copy link
Collaborator Author

Tested this out a bit locally with some simple modifications to use the generated headers in battle_script.c, and it works as expected!

@lhearachel lhearachel merged commit b5159db into pret:main Dec 23, 2023
1 check passed
@lhearachel lhearachel deleted the pl_msg_build_refactor branch February 21, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants