Finishing up journal documentation #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbt6
reviewed
Dec 26, 2024
Comment on lines
119
to
120
| Window *window1; | ||
| Window *window2; |
There was a problem hiding this comment.
Rename to something more meaningful that expresses how the two windows differ (or leave them as v0 and v1 for now if you can't tell).
lhearachel
reviewed
Dec 31, 2024
lhearachel
reviewed
Jan 2, 2025
Comment on lines
364
to
372
| Text_AddPrinterWithParamsAndColor(window, FONT_SYSTEM, journalManager->strbuf, 0, ((16 * 4 + 16) + 16), TEXT_SPEED_NO_TRANSFER, TEXT_COLOR(1, 2, 0), NULL); | ||
| Text_AddPrinterWithParamsAndColor(window, FONT_SYSTEM, journalManager->strbuf, 0, TRAINER_EVENT_Y_OFFSET, TEXT_SPEED_NO_TRANSFER, TEXT_COLOR(1, 2, 0), NULL); |
lhearachel
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably my last PR about the journal. There were just some final things I wanted to improve, like finally giving
UnkStruct_ov81_021D1610an actual name (JournalManager) and giving most functions, params and variables injournal_controller.can actual name as well. Some function names injournal_controller.ccould potentially be improved, I wasn't always exactly sure about what graphics related stuff was happening, so see the names for these more as suggestions.