Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pokedex_data #321

Merged
merged 10 commits into from
Jan 5, 2025
Merged

Document pokedex_data #321

merged 10 commits into from
Jan 5, 2025

Conversation

h2o-DS
Copy link
Contributor

@h2o-DS h2o-DS commented Dec 25, 2024

unk_0202631 -> pokedex_data

This is the file that manages all form data encountered, including genders and languages.

src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Outdated Show resolved Hide resolved
Within PokedexData <species>Forms -> <species>FormsSeen
for pokemon with multiple forms
src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Show resolved Hide resolved
Made ExcludedMons a global variable so that NUM_EXCLUDED can be defined dynamically.
Also added in dummy code for applying exclusions to the local dex.
@h2o-DS h2o-DS requested a review from lhearachel January 4, 2025 17:33
Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more lingering comments. The rest looks great to me. 👍

src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Outdated Show resolved Hide resolved
src/pokedex_data.c Outdated Show resolved Hide resolved
Removed Unnecessary constants.
Gave hex values correct capitalization and padding.
sExcludedMons_national-> sExcludedMonsNational
@lhearachel lhearachel merged commit aa54db5 into pret:main Jan 5, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants