-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document pokedex_data #321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unk_0202631 -> pokedex_data This is the file that manages all form data encountered, including genders and languages.
cbt6
reviewed
Dec 26, 2024
Within PokedexData <species>Forms -> <species>FormsSeen for pokemon with multiple forms
lhearachel
reviewed
Dec 31, 2024
Made ExcludedMons a global variable so that NUM_EXCLUDED can be defined dynamically. Also added in dummy code for applying exclusions to the local dex.
lhearachel
reviewed
Jan 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more lingering comments. The rest looks great to me. 👍
Removed Unnecessary constants. Gave hex values correct capitalization and padding. sExcludedMons_national-> sExcludedMonsNational
lhearachel
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unk_0202631 -> pokedex_data
This is the file that manages all form data encountered, including genders and languages.