Generate Foreign dex entries #324
Conversation
unk_020986CC -> pokedex_language ov21_021D5600 -> pokedex_text
Added foreign pokedex text to pokemon data files Added foreign pokedex message files to tools/scripts/make_pokedex_message_banks.py Renamed message banks 700-723
Decided that diamond dex entries do not need to be generated
Moved pokedex data from data.json to pokedex.yaml Seperated message banks that do not require pokedex data to make_species_message_banks.py
| @@ -1,13 +1,16 @@ | |||
| #!/usr/bin/env python3 | |||
| import argparse | |||
| import json | |||
| import yaml | |||
There was a problem hiding this comment.
Yes. How should I clarify that?
There was a problem hiding this comment.
If it's a new dependency, then we need to both clarify it in the INSTALL.md, provide a way to standardize what version we are pulling (e.g., via a requirements.txt for pip), and set up the Makefile to enforce virtual environments so that users don't have to worry about cross-pollinating project dependencies with their system packages.
There was a problem hiding this comment.
Scratch the above; Mac OS would be left in the dust with that approach. Homebrew has disabled the formula, and the official recommendation is to enforce virtual environments. So, we do need to move towards enforcing virtual environments via the Makefile.
|
|
Added foreign pokedex text to pokemon data files
Added foreign pokedex message files to tools/scripts/make_pokedex_message_banks.py
Renamed message banks 700-723
To be merged after #323