-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document catching_show (unk_020562F8) #328
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the enum in include/unk_0204C500.h
to consts/
(see the files there for example). That way you can use them in field scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I have only a few thoughts listed below; these are non-blocking, but I would like to incorporate the special identifier for cartridge version 0
into this PR, if possible.
unk_020562F8
->catching_show
Deleted
include/struct_decls/struct_020564B4_decl.h
and moved its struct intoinclude/catching_show.h
If you are wondering what a Catching Show even is, this should help.
I like to think of it as Safari Zone -> Pal Park, Safari Game -> Catching Show.
Notes/things I am unsure about:
Is-- taken care of, thank you @cbt6include/unk_0204C500.h
the correct place to add theCATCHING_SHOW_POINTS_CATEGORY
enum? And can I reference that enum inres/field/scripts/scripts_pal_park_lobby.s
? I couldn't figure out how to make that happen, though it feels like it should be an easy thing to do.catching_show.c
revolved aroundNARC_ReadFromMemberByIndexPair
. I haven't done any NARC unpacking yet (RavePossum did give me some good explanations for those though, thanks Rave :D), and I would like to do the follow up PR to this one to unpack it and finish documenting this file.SaveData_PalParkTransfer
, which I was also a bit unsure aboutIf this gets approved, can remove "
unk_020562F8
- Pal Park library" from #325