Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace own installation functions with nypm ensureDependencyInstalled #73

Open
wants to merge 3 commits into
base: ankur-patch
Choose a base branch
from

Conversation

Kuuzoo
Copy link

@Kuuzoo Kuuzoo commented Dec 27, 2024

  • As the title already says, this commits makes use of the ensureDependencyInstalled function provided by nypm.
  • Also, it fixes a small typo in a log message 😄

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-prisma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 4:04am

@ankur-arch
Copy link
Contributor

ankur-arch commented Dec 28, 2024

Thanks for putting up the PR @Kuuzoo 🙌 ! I'll test it out and merge it in.

@Dobefu
Copy link
Contributor

Dobefu commented Dec 30, 2024

Hi @ankur-arch!

@Kuuzoo and I have had a chat in Discord about PR #75. I'll close that one shortly, as they overlap a bit.

During our chat, we were a bit puzzled about the reason why there are checks if the packages prisma and @prisma/client are installed, since they are direct dependencies in the package.json. We think it is safe to remove these functions, unless we are missing something. What do you think about it? Are you perhaps willing to chat about it on Discord?

If these functions can be removed, it would entirely remove the need for the nypm dependency.

Additionally, @Kuuzoo is looking into the possibility of replacing the npx calls with direct function imports. If the Prisma packages provide all the exports we need, it can be called directly without forking the process. We hope to simplify the code a bit by doing this.

@ankur-arch
Copy link
Contributor

During our chat, we were a bit puzzled about the reason why there are checks if the packages prisma and @prisma/client are installed, since they are direct dependencies in the package.json. We think it is safe to remove these functions, unless we are missing something. What do you think about it? Are you perhaps willing to chat about it on Discord?

Hey @Dobefu @Kuuzoo , thanks for the effort! I'm a bit occupied today and will be off tomorrow. Let's have a chat on Discord on the 2nd when I'm back?

@Dobefu
Copy link
Contributor

Dobefu commented Dec 31, 2024

Absolutely, @ankur-arch! Have a nice new year's eve celebration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants