Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: voice credits per poll #1967

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: voice credits per poll #1967

wants to merge 1 commit into from
+438 −690

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 12, 2024 •
edited
Loading

Description

Add custom credits per each poll

Related issue(s)

fix #1854

Confirmation

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jan 7, 2025 10:33am

@ctrlc03 ctrlc03 changed the title Feat/voice credits per poll feat: voice credits per poll Dec 12, 2024
@ctrlc03 ctrlc03 self-assigned this Dec 12, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2024
View reviewed changes
packages/contracts/contracts/MACI.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from 3e2ac79 to 73dcbaa Compare December 12, 2024 21:02
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2024
View reviewed changes
packages/contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from 73dcbaa to f28a05d Compare December 12, 2024 21:26
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from f28a05d to a1c9341 Compare December 18, 2024 10:54
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2024
View reviewed changes
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from a1c9341 to d7a2143 Compare December 18, 2024 11:06
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from d7a2143 to 81ca56d Compare December 18, 2024 14:25
@ctrlc03 ctrlc03 marked this pull request as ready for review December 18, 2024 14:27
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from 81ca56d to 8bfcda7 Compare December 18, 2024 14:37
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch 2 times, most recently from f1779f5 to 58ac013 Compare December 18, 2024 16:53
@ctrlc03 ctrlc03 enabled auto-merge (squash) December 18, 2024 17:38
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from 58ac013 to e0a554f Compare December 19, 2024 11:22
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from e0a554f to e74ea08 Compare December 19, 2024 11:28
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from e74ea08 to 496a934 Compare December 20, 2024 22:42
@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from 496a934 to 8ed05c4 Compare December 23, 2024 10:45
0xmad
0xmad reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just some questions and minor suggestions

packages/cli/deploy-config.json Outdated Show resolved Hide resolved
packages/cli/ts/utils/interfaces.ts Outdated Show resolved Hide resolved
packages/crypto/ts/constants.ts
@@ -10,3 +10,5 @@ export const SNARK_FIELD_SIZE = r;
export const NOTHING_UP_MY_SLEEVE = BigInt(keccak256(toUtf8Bytes("Maci"))) % SNARK_FIELD_SIZE;

assert(NOTHING_UP_MY_SLEEVE === BigInt("8370432830353022751713833565135785980866757267633941821328460903436894336785"));

export const PAD_KEY_HASH = BigInt("1309255631273308531193241901289907343161346846555918942743921933037802809814");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use exactly this value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the poseidon hash of the the PAD_KEY (https://github.com/privacy-scaling-explorations/maci/blob/dev/packages/contracts/contracts/crypto/SnarkConstants.sol#L12) - it's the same key that was part of the blank state leaf, and now because we only need to store the key at the maci state tree, we can directly use this value as init value for the tree

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed the last two lines of this comment are not accurate (https://github.com/privacy-scaling-explorations/maci/blob/dev/packages/contracts/contracts/crypto/SnarkConstants.sol#L18-L19), that hash starting 67 refers to the hash of the blank state leaf

@ctrlc03 ctrlc03 force-pushed the feat/voice-credits-per-poll branch from 8ed05c4 to 00e9328 Compare January 7, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad left review comments

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ctrlc03 ctrlc03

Labels
None yet
Projects
MACI
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom voice credit proxy per poll
2 participants
@ctrlc03 @0xmad