Inter user communication #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshsaxena
requested changes
Jan 9, 2019
There was a problem hiding this comment.
General comments:
- Prettify your HTML, Python and JS files. Follow the alignment and variable-naming conventions - people must find your code readable.
- PEP8 standard is used for Python files - you can use autopep8 tool to detect and fix most of your errors.
- README can be removed, or its content added to the existing README file (not necessary).
| @@ -0,0 +1,5 @@ | |||
| #inter-user communication | |||
There was a problem hiding this comment.
This file might not be needed.
| @@ -0,0 +1,9 @@ | |||
| <html> | |||
| <body> | |||
| <form action = "http://localhost:5000/login" method = "get"> | |||
There was a problem hiding this comment.
We should have a relative path instead of a fixed one.
| @@ -0,0 +1,27 @@ | |||
| from flask import Flask,render_template,redirect,request,url_for | |||
There was a problem hiding this comment.
Have a white-space after every comma.
| @app.route('/chat/<user>') | ||
| def chat(user): | ||
| return render_template('chat.html',user=user) | ||
| app.config['SECRET_KEY'] = 'secret!' |
There was a problem hiding this comment.
All secret-keys can be kept in a file, and that file should not be committed.
| socketio = SocketIO(app) | ||
| @socketio.on('message') | ||
| def handle_message(message): | ||
| print(message) |
There was a problem hiding this comment.
You can use the logging module from Python instead of print methods.
| <body> | ||
| <form action = "http://localhost:5000/login" method = "get"> | ||
| <p>Enter Name:</p> | ||
| <p><input type = "text" name = "nm" /></p> |
There was a problem hiding this comment.
Can nm be changed to name ?
| $("#messages").append('<li>'+msg+'</li>'); | ||
| console.log('Received message'); | ||
| }); | ||
| $('#sendbutton').on('click', function() { |
There was a problem hiding this comment.
Use sendButton instead of sendbutton. Notice the camel-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.