For recursive or cyclic blueprints, halt after 10 levels by default #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhollinger
force-pushed
the
fix-recursive-blueprint
branch
from
03f5f48 to
e927ff7
Compare
jhollinger
force-pushed
the
fix-recursive-blueprint
branch
from
e927ff7 to
c9b0ced
Compare
jhollinger
force-pushed
the
fix-recursive-blueprint
branch
6 times, most recently
from
a9cc576 to
a367138
Compare
jhollinger
changed the title
jhollinger
force-pushed
the
fix-recursive-blueprint
branch
from
a367138 to
8e23ecc
Compare
lessthanjacob
previously approved these changes
Jun 26, 2024
| @@ -42,7 +42,7 @@ def initialize(&log_proc) | |||
| def pre_render(object, blueprint, view, options) | |||
| if object.is_a?(ActiveRecord::Relation) && object.before_preload_blueprint | |||
| from_code = object.before_preload_blueprint | |||
| from_blueprint = Preloader.preloads(blueprint, view, object.model) | |||
| from_blueprint = Preloader.preloads(blueprint, view, model: object.model) | |||
There was a problem hiding this comment.
non-blocking: Worth making all of these kwargs if we're changing model?
jhollinger
force-pushed
the
fix-recursive-blueprint
branch
from
8e23ecc to
ac138a0
Compare
jhollinger
changed the title
Signed-off-by: Jordan Hollinger <[email protected]>
Signed-off-by: Jordan Hollinger <[email protected]>
jhollinger
force-pushed
the
fix-recursive-blueprint
branch
from
ac138a0 to
ba94307
Compare
lessthanjacob
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #13, where we get infinite recursion when a blueprint has an association to
self, or when it's part of a cycle. Now it will halt preloading after 10 cycles. If that's not enough, it can be increased: