Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #26] Make pre_render compatible with all children of ActiveRecord::Relation #28

Merged
merged 2 commits into from
Jun 25, 2024
Merged

[Issue #26] Make pre_render compatible with all children of ActiveRecord::Relation #28

merged 2 commits into from
Jun 25, 2024

Conversation

ryanmccarthypdx
Copy link
Contributor

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@ryanmccarthypdx ryanmccarthypdx requested a review from a team as a code owner June 24, 2024 15:17
@ryanmccarthypdx ryanmccarthypdx force-pushed the enable_preloading_on_collection_proxy branch from 6d91d57 to 828486b Compare June 24, 2024 15:20
@ryanmccarthypdx ryanmccarthypdx force-pushed the enable_preloading_on_collection_proxy branch from 828486b to 8db4f20 Compare June 24, 2024 15:21
@ryanmccarthypdx ryanmccarthypdx mentioned this pull request Jun 24, 2024
Closed
@jhollinger
Copy link
Contributor

Have to study this more to make sure, but at a glance it seems like the perfect idea. Nice!

jhollinger
jhollinger requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@jhollinger jhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one quibble about the tests.

test/nested_render_test.rb Outdated Show resolved Hide resolved
@ryanmccarthypdx
Make CollectionProxy test valid
efe6db4 
Signed-off-by: Ryan McCarthy <[email protected]>
@ryanmccarthypdx ryanmccarthypdx force-pushed the enable_preloading_on_collection_proxy branch from 4d291fc to efe6db4 Compare June 24, 2024 21:34
@jhollinger jhollinger merged commit 2b39b67 into procore-oss:main Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhollinger jhollinger jhollinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanmccarthypdx @jhollinger