Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for latest kwok #626

Closed
wants to merge 6 commits into from
Closed

Conversation

jbusche
Copy link
Contributor

@jbusche jbusche commented Sep 7, 2023

Issue link

#625

What changes have been made

  • Fixed the KWOK install instructions to the latest (easier) method
  • fixed the Items problem so that appwrappers launch
  • specify the full crd path so there's no confusion between the appwrappers.mcad.ibm.com and appwrappers.workload.codeflare.dev

Verification steps

Will be testing throughly - TBD

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@jbusche
Copy link
Contributor Author

jbusche commented Sep 14, 2023

Tested on my new Cluster with the latest MCAD and CodeFlare - it's looking good. Install instructions are simplified, the CRDs are looking good, and it's deploying well.

./nodes.sh 
Checking whether we have a valid cluster login or not...

Nice, looks like you're logged in

Checking MCAD Controller installation status

Nice, the KWOK Controller is installed

How many simulated KWOK nodes do you want?3
Nodes number is 3
 
The real number of nodes is 2
Submitting node 1
node/kwok-node-1 created
Submitting node 2
node/kwok-node-2 created
Submitting node 3
node/kwok-node-3 created
Waiting until all the simualted pods become ready:
node/kwok-node-1 condition met
node/kwok-node-2 condition met
node/kwok-node-3 condition met
 
Total amount of simulated nodes requested is: 3
Total number of created nodes is: 3
NAME          STATUS   ROLES   AGE   VERSION
kwok-node-1   Ready    agent   1s    fake
kwok-node-2   Ready    agent   1s    fake
kwok-node-3   Ready    agent   0s    fake

@jbusche jbusche marked this pull request as ready for review September 14, 2023 16:18
@asm582
Copy link
Member

asm582 commented Sep 14, 2023

/LGTM

@openshift-ci openshift-ci bot removed the lgtm label Sep 26, 2023
Copy link
Contributor

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this /lgtm once the docs change comes in. Thanks for walking through this with me

Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Copy link

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KPostOffice
Once this PR has been reviewed and has the lgtm label, please ask for approval from asm582. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbusche
Copy link
Contributor Author

jbusche commented Dec 5, 2023

Closing pull request, re-submitting a new one

@jbusche jbusche closed this Dec 5, 2023
@jbusche jbusche deleted the jimb-issue-625 branch January 16, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants