Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Move cluster assignment from status to spec #643

Open
wants to merge 20 commits into
base: release-v1.31.0
Choose a base branch
from
Open

[WIP] Move cluster assignment from status to spec #643

wants to merge 20 commits into from

Conversation

cwiklik
Copy link

@cwiklik cwiklik commented Sep 21, 2023

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Jaroslaw Cwiklik and others added 19 commits August 21, 2023 12:34
using 1.32.0 tag
87a1201
@dmatch01
Added stanze def. for clusterscheduling.
7715679
@dmatch01
Added and fixed example.
bcd4127 
Signed-off-by: dmatch01 <[email protected]>
@dmatch01
Added api field for targetClusterName
f8c7031 
Signed-off-by: dmatch01 <[email protected]>
@dmatch01
Merge pull request #2 from cwiklik/mcad-v131-add-cluster-status-field
85ab98b 
Added api field for targetClusterName
added support for setting targetClusterName in status
0afc21f
added support to set target cluster id and delete appwrapper when no …
0cbb7fb 
…longer needed
fixed assignment for targetClusterName and modified cleanup()
9e1821a
modified helm related resources to support new option externalDispatch
40b121f
fixed wrong assignment of targetClusterName
7d97f3e
more fixes to support setting targetClusterName
fd0d436
@cwiklik
Merge pull request #3 from cwiklik/set-targetClusterName-in-spec
0976f11 
added support for setting targetClusterName in status
fixes supporting status
e972e07
add completion status to every item in a pipeline
9f67d0f
simplified implementation of gvk in completion status for each item i…
0bbda5a 
…n the workload
redone gvk. Modified dispatcher so that it handled job completion status
c795e2a
add new status-check test suite
bc0966d
moved cluster assignment to spec
f3aea37
added clusterDecision to appwrappers crd
c192f7e
@openshift-ci openshift-ci bot requested a review from dmatch01 September 21, 2023 20:08
@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dmatch01 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatch01 dmatch01 Awaiting requested review from dmatch01

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwiklik @dmatch01