-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed target parsing #1137
base: master
Are you sure you want to change the base?
Fixed target parsing #1137
Conversation
daeae50
to
55a9c34
Compare
Hi, @electron0zero ! |
0f5e3c3
to
b8709c3
Compare
Improved http(s) scheme check so that target may be passed in lower and upper cases. Signed-off-by: Roman Astrakhantsev <[email protected]> Signed-off-by: Suraj Nath <[email protected]>
Signed-off-by: Roman Astrakhantsev <[email protected]> Signed-off-by: Suraj Nath <[email protected]>
Signed-off-by: Roman Astrakhantsev <[email protected]> Signed-off-by: Suraj Nath <[email protected]>
b8709c3
to
df0ab5d
Compare
@Astrarog the CI has been failing, can you sync your fork, and rebase the PR please. will merge once CI is green ✅ |
df0ab5d
to
9984371
Compare
Signed-off-by: Suraj Nath <[email protected]>
The fork is synced already. |
Improved http(s) scheme check so that target may be passed in lower and upper cases.
Before the fix works only schemes:
After the fix also works schemes alike: