Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed target parsing #1137

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed target parsing #1137

wants to merge 4 commits into from

Conversation

Astrarog
Copy link

Improved http(s) scheme check so that target may be passed in lower and upper cases.

Before the fix works only schemes:

  • http://
  • https://

After the fix also works schemes alike:

  • HTTPS://
  • HtTp://

prober/http.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the stale label Sep 19, 2024
@Astrarog Astrarog force-pushed the patch-1 branch 2 times, most recently from daeae50 to 55a9c34 Compare November 25, 2024 04:09
@Astrarog
Copy link
Author

Hi, @electron0zero !
I've added different tests cases and looks like they've all passed.

@github-actions github-actions bot removed the stale label Nov 25, 2024
prober/http.go Outdated Show resolved Hide resolved
Improved http(s) scheme check so that target may be passed in lower and upper cases.

Signed-off-by: Roman Astrakhantsev <[email protected]>
Signed-off-by: Suraj Nath <[email protected]>
Signed-off-by: Roman Astrakhantsev <[email protected]>
Signed-off-by: Suraj Nath <[email protected]>
Signed-off-by: Roman Astrakhantsev <[email protected]>
Signed-off-by: Suraj Nath <[email protected]>
@electron0zero
Copy link
Member

Hi, @electron0zero ! I've added different tests cases and looks like they've all passed.

@Astrarog the CI has been failing, can you sync your fork, and rebase the PR please. will merge once CI is green ✅

Signed-off-by: Suraj Nath <[email protected]>
@Astrarog
Copy link
Author

Hi, @electron0zero ! I've added different tests cases and looks like they've all passed.

@Astrarog the CI has been failing, can you sync your fork, and rebase the PR please. will merge once CI is green ✅

The fork is synced already.
In CI failing test which are GRPC related. I believe that this fix doesn't correlate with GRPC functions and test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants