Update Input Dialog to use Validator #1747
Open
+53
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should Fix Issue #1715 |
| ) | ||
|
|
||
| # Extract buffer validation errors for buffer UIControl children classes | ||
| def get_buffer_from_content(content: UIControl) -> bool: |
There was a problem hiding this comment.
Could you rename this? This doesn't return the buffer. For instance control_has_validation_error().
This PR looks good otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Input Dialog accepts a Validator as a parameter but does not actually display anything via the UI. This PR fixes the following:
validate_while_typingtoinput_dialogand passes along to TextField.has_any_validation_errorfilter that returns if any buffer in the application layout has a validation error.ValidationToolbarto accept a specific buffer object rather than just the currently focused buffer.input_dialogobject to validate when OK button is activated and prevent closing while validation errors exist.