fix: throw error for nonzero exit code, after posting (#116)

promptfoo · Feb 21, 2024 · 831a73d · 831a73d
1 parent 2c774ac
commit 831a73d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/main.ts b/src/main.ts
@@ -145,15 +145,12 @@ export async function run(): Promise<void> {
       ...(vertexApiKey ? {VERTEX_API_KEY: vertexApiKey} : {}),
       ...(cachePath ? {PROMPTFOO_CACHE_PATH: cachePath} : {}),
     };
+    let errorToThrow: Error | undefined;
     try {
       await exec.exec(`npx promptfoo@${version}`, promptfooArgs, {env});
     } catch (error) {
-      // Ignore nonzero exit code
-      if (error instanceof Error) {
-        core.info(`promptfoo exited with error: ${error.message}`);
-      } else {
-        core.info(`promptfoo exited with an unknown error.`);
-      }
+      // Ignore nonzero exit code, but save the error to throw later
+      errorToThrow = error as Error;
     }
 
     // Comment PR
@@ -179,6 +176,10 @@ export async function run(): Promise<void> {
       issue_number: pullRequest.number,
       body,
     });
+
+    if (errorToThrow) {
+      throw errorToThrow;
+    }
   } catch (error) {
     if (error instanceof Error) {
       handleError(error);