-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation method in list.html.erb #11213
Add translation method in list.html.erb #11213
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## main #11213 +/- ##
==========================================
- Coverage 82.45% 82.34% -0.12%
==========================================
Files 98 98
Lines 5992 5992
==========================================
- Hits 4941 4934 -7
- Misses 1051 1058 +7
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
I'm so sorry @jenniferhalloran, that was a mistake on my end. The correct link to the file is this https://github.com/publiclab/plots2/blob/main/config/locales/en.yml#L160. Sorry for the inconvenience! |
Code Climate has analyzed commit 2515321 and detected 0 issues on this pull request. View more on Code Climate. |
@TildaDares don't worry at all! I think I have updated the correct page now. :) |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @jenniferhalloran. Thank you!!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Thank you @TildaDares! I am looking forward to learning more about open source coding with ya'll :) |
I have made the changes asked in app/voews/users/list.html.erb and added the translation method, but I had an issue trying to find the changes I needed to make in config/en.yml. Such file does not seem to exist, so I tried looking in config/locale/en.yml but I did not see the line of code that I should change.
If someone would like to guide me in the right direction I am happy to update this pull request!
Fixes #11205
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below