-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes of #11355 done. #11453
Changes of #11355 done. #11453
Conversation
Changes mentioned in #11355 issue are done as mentioned.
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11453 +/- ##
==========================================
+ Coverage 77.14% 82.52% +5.38%
==========================================
Files 96 96
Lines 6051 5946 -105
==========================================
+ Hits 4668 4907 +239
+ Misses 1383 1039 -344
|
Fixed the errors mentioned previously by @cesswairimu.
Code Climate has analyzed commit 3aa456e and detected 0 issues on this pull request. View more on Code Climate. |
Hello @cesswairimu. I have done the changes, can you please review them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 🎉 🎉
Thank you @cesswairimu. Do I have to close the PR? |
No, I will merge it once the checks are completed |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Changes mentioned in #11355 issue are done as mentioned.
Fixes #11451