-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #9418 : add notes_for_tags method in user model #11474
Fixes #9418 : add notes_for_tags method in user model #11474
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Hey @TildaDares! Hope you are doing well! Please review this PR. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11474 +/- ##
==========================================
- Coverage 83.33% 83.20% -0.14%
==========================================
Files 93 93
Lines 5772 5774 +2
==========================================
- Hits 4810 4804 -6
- Misses 962 970 +8
|
Code Climate has analyzed commit 90c0ec9 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Let's get a second opinion from @jywarren.
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Great job, this looks good! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Fixes #9418
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowScreenshot
URL -
http://localhost:3000/notes/author/admin/lat:53