Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditional installation guide for gnupg2 #11480

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

7malikk
Copy link
Contributor

@7malikk 7malikk commented Oct 13, 2022

Fixes #11479

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled πŸ“‘ and links the original issue above πŸ”—
  • tests pass -- look for a green checkbox βœ”οΈ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in a uniquely-named feature branch and has no merge conflicts πŸ“
  • screenshots/GIFs are attached πŸ“Ž in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Oct 13, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help πŸ’Ώ
There may be some errors, but don't worry! We'll work through them with you! πŸ‘πŸŽ‰πŸ˜„


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! πŸ™Œ


Then, you can say hello in our chatroom & share a link to this PR to get a review! πŸ‘‹ βœ…

@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 13, 2022

Code Climate has analyzed commit 2ed1057 and detected 0 issues on this pull request.

View more on Code Climate.

@7malikk
Copy link
Contributor Author

7malikk commented Oct 13, 2022

Hello, @cesswairimu @TildaDares kindly review my PR, its a fix for 11479

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8765631889/artifacts/397474995

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #11480 (c595d9e) into main (21dfe4c) will increase coverage by 5.43%.
The diff coverage is n/a.

❗ Current head c595d9e differs from pull request most recent head 2ed1057. Consider uploading reports for the commit 2ed1057 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11480      +/-   ##
==========================================
+ Coverage   77.89%   83.33%   +5.43%     
==========================================
  Files          93       93              
  Lines        5877     5772     -105     
==========================================
+ Hits         4578     4810     +232     
+ Misses       1299      962     -337     
Impacted Files Coverage Ξ”
app/models/node.rb 91.04% <0.00%> (+0.34%) ⬆️
app/models/user.rb 86.49% <0.00%> (+1.09%) ⬆️
app/controllers/user_sessions_controller.rb 67.48% <0.00%> (+1.22%) ⬆️
app/controllers/wiki_controller.rb 82.85% <0.00%> (+1.78%) ⬆️
app/models/image.rb 82.05% <0.00%> (+2.56%) ⬆️
app/models/spamaway.rb 97.43% <0.00%> (+2.56%) ⬆️
app/controllers/admin_controller.rb 80.24% <0.00%> (+5.76%) ⬆️
app/controllers/home_controller.rb 95.65% <0.00%> (+5.79%) ⬆️
app/controllers/users_controller.rb 80.78% <0.00%> (+9.25%) ⬆️
app/controllers/application_controller.rb 90.62% <0.00%> (+9.37%) ⬆️
... and 3 more

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great πŸŽ‰ thanks for working on this

@cesswairimu cesswairimu merged commit 12019d7 into publiclab:main Oct 14, 2022
@welcome
Copy link

welcome bot commented Oct 14, 2022

Congrats on merging your first pull request! πŸ™ŒπŸŽ‰βš‘οΈ
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did πŸ˜ƒ. Please find the link to our latest check-in here πŸ“
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. πŸ™Œ

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! πŸ˜•

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! πŸ˜„ πŸŽ‰

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors πŸ“₯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants