TTK-27420: Add condition to check if profile tags exist (#690)

* TTK-27420: Add condition to check if profile tags exist * TTK-27420: Add condition to check if target profile property exists --------- Co-authored-by: Pablo Ogando Ferreira <[email protected]>
pumukit · Dec 18, 2024 · 153f19d · 153f19d
1 parent b7afeda
commit 153f19d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Pumukit/SchemaBundle/Services/MediaCreator.php b/src/Pumukit/SchemaBundle/Services/MediaCreator.php
@@ -107,8 +107,10 @@ public function generateProfileTags(Job $job, array $profile): Tags
         if ($profile['display']) {
             $tags[] = 'display';
         }
-        foreach (array_filter(preg_split('/[,\s]+/', $profile['tags'])) as $tag) {
-            $tags[] = trim($tag);
+        if (!empty($profile['tags'])) {
+            foreach (array_filter(preg_split('/[,\s]+/', $profile['tags'])) as $tag) {
+                $tags[] = trim($tag);
+            }
         }
 
         return Tags::create($tags);

diff --git a/src/Pumukit/WorkflowBundle/EventListener/JobGeneratorListener.php b/src/Pumukit/WorkflowBundle/EventListener/JobGeneratorListener.php
@@ -192,7 +192,8 @@ private function ensureProfileExists(MultimediaObject $multimediaObject): ?array
 
     private function hasEncodedJobForProfile(MediaInterface $master, Tag $pubChannel, array $profile): bool
     {
-        return $master->tags()->containsTag('ENCODED_'.$pubChannel->getCod()) && str_contains($profile['target'], $pubChannel->getCod());
+        return $master->tags()->containsTag('ENCODED_'.$pubChannel->getCod()) && isset($profile['target'])
+            && is_string($profile['target']) && str_contains($profile['target'], $pubChannel->getCod());
     }
 
     private function hasMediaWithProfileTarget(MultimediaObject $multimediaObject, Tag $pubChannel): bool
@@ -204,6 +205,10 @@ private function hasMediaWithProfileTarget(MultimediaObject $multimediaObject, T
                 continue;
             }
 
+            if (!isset($this->profiles[$profileName]['target']) || !is_string($this->profiles[$profileName]['target'])) {
+                continue;
+            }
+
             $targets = $this->getTargets($this->profiles[$profileName]['target']);
             if (!in_array($pubChannel->getCod(), $targets['standard'])) {
                 continue;