Added a Dockerfile for experimenting with precompiled bins #35
Conversation
I put this together for my own purposes but sharing here as it's likely useful for others. A couple of related thoughts: * I'll update the docs with instructions for mounting providers for testing once puppetlabs-toy-chest#34 is resolved. * I could have used the new multi-state builds to avoid some of the apt wranging, but left this way for now until multi-stage builds works it's way into a stable Docker release * This only supports building from the precompiled binary. I'll take a run at converting the HACKING instructions at some point so you can build using Docker, that should be a separate PR I also haven't pushed an image to Docker Hub. I would be happy to do that if useful or hold off for now.
|
This is pretty neat - I'd like to merge it, but can we move |
|
I can move it elsewhere, but I would recommend putting it at the top level of the project. I think increasingly that's coming the norm, I personally just look for a Dockerfile at the top level of a project whenever I start looking at something. I think that only becomes more common over time. I did find the build Dockerfiles in contrib, but actually after I'd issued this PR, hence the 3rd bullet which is actually already done. Happy to go with what you'd prefer, but my advice would be keep it at the top level as a first class part of the project. |
|
Ok. That makes sense to me. Merged as-is. |
I put this together for my own purposes but sharing here as it's likely
useful for others. A couple of related thoughts:
testing once Ralsh not picking up providers automatically #34 is
resolved.
apt wranging, but left this way for now until multi-stage builds works
it's way into a stable Docker release
run at converting the HACKING instructions at some point so you can
build using Docker, that should be a separate PR
I also haven't pushed an image to Docker Hub. I would be happy to do
that if useful or hold off for now.