(PUP-12083) Update soft limit warning for fact value length and fact name length #9514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
added
enhancement
joshcooper
reviewed
Oct 30, 2024
AriaXLi
force-pushed
the
PUP-12083/fact_name_in_soft_limit_warnings
branch
from
7fe146b to
5d6de1b
Compare
AriaXLi
changed the title
AriaXLi
force-pushed
the
PUP-12083/fact_name_in_soft_limit_warnings
branch
from
5d6de1b to
dc0d2e6
Compare
joshcooper
reviewed
Oct 31, 2024
AriaXLi
force-pushed
the
PUP-12083/fact_name_in_soft_limit_warnings
branch
4 times, most recently
from
4f6d10d to
bee3a55
Compare
This commit updates the warning for exceeding the fact value length soft limit to include the fact name and updates the warning for exceeding the fact name length soft limit to give the fact name with dots & include the length that was used to evaluate if the length exceeds the limit.
AriaXLi
force-pushed
the
PUP-12083/fact_name_in_soft_limit_warnings
branch
from
bee3a55 to
2754ee2
Compare
mhashizume
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the soft limit warning for fact value length to include
the fact name and updates the soft limit warning for fact name length to
include the length that was used to evaluate if the length exceeds the limit.