Skip to content

Commit

Permalink
minor improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
pvyleta committed Mar 24, 2024
1 parent cdf7900 commit b4be14d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@
converters_set: set[str] = {c for c in converters_map.keys()}
unused_converters_set = converters_set - used_converters_set


# 0. check if parameters are always a subset for lower version
# Make the output of joined files for a given device and SW version
# Publish known files to ebusd configuration, distinguish them by dipswitch for 3c and 7c
# consider adding comments for version
# 1. re-define scan for SW so that the string is parsed as integers
# 2. check the scan results on real device
# 3. write code to parse SW version to match the sw received
Expand Down
2 changes: 1 addition & 1 deletion src/out.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def csv_known_device(sensors: list[Sensor], device_name: str, parameters: list[P
## sources:
## - Original idea and some dividers: https://github.com/dstrigl/ebusd-config-brink-renovent-excellent-300
## - Brink Service Tool (decompiled via Jetbrains DotPeak): https://www.brinkclimatesystems.nl/tools/software-brink-service-tool-en
## - Renovent 180 Datasheet: https://www.rosain.cz/dokumenty/Technicky-list-Renovent-Excellent-180.pdf
## - Renovent 150 Datasheet: https://manuals.plus/brink/renovent-sky-150-plus-mechanical-ventilation-with-heat-recovery-manual
## - Modbus Module Datasheet: https://www.brinkclimatesystems.nl/documenten/modbus-uwa2-b-uwa2-e-installation-regulations-614882.pdf
## COMMON HRU COMMANDS ## (WTWCommands.cs)
Expand Down

0 comments on commit b4be14d

Please sign in to comment.