removed best.improvement from is_children_impurity_proxy condition

Signed-off-by: Gabriel Daiha <[email protected]>
py-why · May 10, 2024 · 1d44cef · 1d44cef
1 parent 0df03b6
commit 1d44cef
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/econml/tree/_splitter.pyx b/econml/tree/_splitter.pyx
@@ -630,8 +630,8 @@ cdef class BestSplitter(Splitter):
                     best.impurity_left_val = best.impurity_left
                     best.impurity_right_val = best.impurity_right
 
-                best.improvement = self.criterion.impurity_improvement(impurity, 
-                best.impurity_left, best.impurity_right)                    
+            best.improvement = self.criterion.impurity_improvement(impurity, 
+            best.impurity_left, best.impurity_right)                    
 
         # Respect invariant for constant features: the original order of
         # element in features[:n_known_constants] must be preserved for sibling