-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various failures in tests #404
Conversation
See: http://mba.tuck.dartmouth.edu/pages/faculty/ken.french/Data_Library/changes_crsp.html Please note: CRSP has recently completed the Pre62 Daily Data Series Project. The addition of these new daily data results in changes to month-end prices and to dividend ex-dates. These changes have resulted in many small changes to historical returns on my website.
Add note to docs re: status of google quotes rebase
cffa531
to
08a700e
Compare
Uses non-weekend date for test, using a weekend date is ambiguous squash
8c64bd7
to
4dfafd7
Compare
@davidastephens For the Google Finance test fix, the use of pytest.skip That way we can later run: |
hi @davidastephens -- could you kindly summarize what was fixed? Many disparate issues were closed, so it might be useful to In what pandas_datareader version will the fixes be distributed? Thanks! |
Hi @rsvp: Each commit has detail as to what was fixed. I aggregated into one pull request so I could get the travis tests to pass. These fixes will be distributed in 0.6.0, but unfortunately, a significant portion of this package no longer works due to API removals. I've noted which apis no longer work in the docs and skipped the tests, but unsure if we should do anything in the code. Would adding DeprecationWarnings be helpful? |
@davidastephens: hi, I think DeprecationWarnings would be most helpful My best summary is here: rsvp/fecon235#7 |
No description provided.