Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to baipp #524

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RonnyPfannschmidt
Copy link
Member

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left a few suggestions.

.github/workflows/main.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated
[project]
name = "pluggy"
license = {text = "MIT"}
authors = [{name = "Holger Krekel", email = "[email protected]"}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it should we update this? Not sure to what exactly though...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm up for being on the hook

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm up for being on the hook

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking more if it is appropriate to add pytest core team <[email protected]> or something like that.

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyproject.toml migration LGTM, I'm not qualified to review the rest. Maybe adding pyproject.fmt first in pre-commit would be great.

@nicoddemus
Copy link
Member

@RonnyPfannschmidt gentle ping here.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@nicoddemus
Copy link
Member

Probably worth updating the title/description of the PR before merging.

@RonnyPfannschmidt RonnyPfannschmidt changed the title migrate to https://github.com/hynek/build-and-inspect-python-package/ migrate to pyproject.toml and baipp Dec 21, 2024
@RonnyPfannschmidt RonnyPfannschmidt changed the title migrate to pyproject.toml and baipp migrate to baipp Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants