Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore </> in step parameter values #465

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jirikuncar
Copy link
Member

closes #447

@jirikuncar jirikuncar requested review from olegpidsadnyi and youtux and removed request for olegpidsadnyi December 15, 2021 13:01
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #465 (3a33d30) into master (f4ed62d) will decrease coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   95.91%   95.87%   -0.05%     
==========================================
  Files          49       49              
  Lines        1640     1647       +7     
  Branches      179      182       +3     
==========================================
+ Hits         1573     1579       +6     
  Misses         41       41              
- Partials       26       27       +1     
Impacted Files Coverage Δ
tests/feature/test_steps.py 100.00% <ø> (ø)
pytest_bdd/parser.py 99.11% <85.71%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ed62d...3a33d30. Read the comment docs.

@jirikuncar
Copy link
Member Author

Coverage should collect information from child processes too ⬆️ .

@youtux
Copy link
Contributor

youtux commented Dec 15, 2021

Coverage should collect information from child processes too ⬆️ .

Any idea on how to make that happen?

@jirikuncar
Copy link
Member Author

jirikuncar commented Dec 15, 2021

@youtux since we are using testdir fixture I would look at passing --cov parameters to sub tests or try using runpytest_inprocess instead.

@jirikuncar jirikuncar enabled auto-merge December 15, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: KeyError in replacer
2 participants