Bugfix for approx on mismatched dictionaries #13046
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over other_side by retrieving values using approx_key
for more information, see https://pre-commit.ci
|
It is missing the changelog, could you please add it? |
added 2 commits
December 20, 2024 00:29
…om/dvdliu/pytest into dvdliu/approx_mismatch_dict_bugfix
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
|
@nicoddemus @RonnyPfannschmidt , I also had this problem recently and this seems to be a nice fix. Could you review and approve if you are fine with it please? |
RonnyPfannschmidt
requested changes
Dec 26, 2024
| for (approx_key, approx_value), other_value in zip( | ||
| approx_side_as_map.items(), other_side.values() | ||
| ): | ||
| for approx_key, approx_value in approx_side_as_map.items(): |
There was a problem hiding this comment.
I just noted that the fix ignores additional keys in the other side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Closes #12444
Tests
Regression test added for the issue mentioned in the above issue