Added Python 3.13 to manylinux build images #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Nov 9, 2024
| @@ -3,7 +3,7 @@ TARGET := $(notdir $(WD)) | |||
| ROOT := $(abspath $(WD)/../Pillow) | |||
| IMAGENAME := $(if $(DOCKER_USERNAME), $(DOCKER_USERNAME)/$(TARGET), $(TARGET)) | |||
| BRANCH := $(shell git rev-parse --abbrev-ref HEAD) | |||
| TEST_TARGET = ubuntu-24.04-noble-amd64 | |||
| TEST_TARGET = fedora-41-amd64 | |||
There was a problem hiding this comment.
Because Fedora 41 comes with Python 3.13, and Ubuntu 24.04 comes with 3.12?
I've not been using these manylinux images locally, what's the other pros/cons of switching?
Does it affect the main Pillow CI?
There was a problem hiding this comment.
Yes, the Python version is why.
I don't expect there to be any side effects of changing the test image - it won't affect the build itself. As the README says
The test target here is mainly to validate the image build, it is assumed that the builds will be used for other purposes or tested in other images.
The wheel build jobs aren't used by the main repository.
radarhere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.