Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111178: fix UBSan failures for gdbmobject #128178

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Dec 22, 2024

Just for something I thought of when I was doing those UBSan tasks:

  • for static types, I can add an assert on the type.
  • for dynamic types, I need the state if I want my assert.

AFAIR, I skipped the assert when the type is internal and dynamic (namely I used a simple pointer cast). For now, I suggest keeping the macro form since it wouldn't really matter if we just have a static inline function without the assertion check.

I've also suppressed an unused return value just for my IDE to be happy but I can revert the commit if needed.

@encukou encukou merged commit baf6571 into python:main Jan 10, 2025
47 checks passed
@picnixz picnixz deleted the fix/ubsan/gdbm-111178 branch January 11, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants