gh-109959: attempt to fix hypothesis tests for test_glob
#128255
Draft
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've rerun lots of times the hypothesis workflow and didn't encounter issues but I really don't know if this is meaningful. @barneygale WDYT? |
|
I know I speculated that this area of code could be related, but on reflection I think it's very unlikely. Given the behaviour Alyssa analysed, if this code were related, then only a bug in |
|
What's also really weird is that I'm locally never seeing this failure. I don't know if this may be something related to the machine the hypothesis tests are actually running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to see if this approach would work or not. Tests are likely to be flaky but I want at least to isolate the failure if possible...