gh-128307: add eager_start kwarg to asyncio.create_task #128306
Conversation
graingert
commented
Dec 28, 2024
•
graingert
commented
- Issue: add start_eager parameter to asyncio.create_task #128307
graingert
changed the title
graingert
changed the title
graingert
force-pushed
the
add-eager-start-to-create-task
branch
from
c809133 to
2f101b3
Compare
| task = self._task_factory(self, coro, context=context) | ||
|
|
||
| task.set_name(name) | ||
| task.set_name(name) |
There was a problem hiding this comment.
this set_name is too late because the task could have already run - so it needs a bit of thought
There was a problem hiding this comment.
We can check first if the task factory exactly is eager_task_factory, and call it with all provided arguments.
The last resort for unknown task factory could have flaws.
On the other side, we can use inspect.signature() + some form of cache to analyze in runtime what arguments are accepted. I'm not a big fan of this approach, but maybe we have not choice.
Support of third-party tasks and factories adds a mess; we should live with it.
Misc/NEWS.d/next/Library/2024-12-28-11-01-36.gh-issue-128307.BRCYTA.rst
Outdated
Show resolved
Hide resolved
|
|
yup, it's in I just forgot to add it to the news |
