Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 751: address some feedback #4104

Merged
merged 1 commit into from
Nov 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions peps/pep-0751.rst
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ specified for the same reason.
- Table
- Record of the tool that generated the lock file.
- Enough details SHOULD be provided such that the lock
file from the details in this table (provided the same I/O data is available,
e.g., Dependabot if only files from a repository is necessary to run the
command).
file from the details in this table can be reproduced (provided the same I/O
data is available, e.g., Dependabot if only files from a repository is
necessary to run the command).


``locker.name``
Expand Down Expand Up @@ -358,7 +358,10 @@ specified for the same reason.
- Array of tables
- A record of the dependency requirements of the package and version.
- The values MUST semantically match what's provided by the package version via
:ref:`packaging:core-metadata-requires-dist`.
:ref:`packaging:core-metadata-requires-dist` for all dependencies referenced
in the lock file (i.e all base dependencies plus all dependencies for extras
referenced in the lock file); lock files MAY list all dependencies for unused
extras if desired.
- Values in the array SHOULD be written as inline tables, sorted
lexicographically by ``name``, then by ``feature`` with the lack of that key
sorting first.
Expand Down Expand Up @@ -783,8 +786,9 @@ Expectations for Installers
- Installers MUST error out if a package version lacks a way to install into the
chosen environment.
- Installers MUST support installing into an empty environment
- Installers SHOULD support syncing a pre-existing environment to match the lock
file.
- Installers SHOULD support uninstalling all packages in a pre-existing
environment and then installing into it (sometimes referred to as *syncing*
an environment to the lock file).
- Installers MAY support a way to install into a pre-existing environment that
tries to keep packages not listed in the lock file working.

Expand Down
Loading