Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add turtledemo module #13192

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add turtledemo module #13192

wants to merge 5 commits into from

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Dec 4, 2024

This isn't terribly useful, but they're not that complicated either.

This comment has been minimized.

This comment has been minimized.

@JelleZijlstra
Copy link
Member

I'd like to hear what other maintainers think, but I'm not sure this is worth adding. It's a reasonably large amount of code to maintain, and it's clearly not meant for people to import.

@tungol
Copy link
Contributor Author

tungol commented Dec 4, 2024

That's fair. I think the code is relatively stable, although I did discover that turtledemo.clock had a bugfix for 3.12+.

Like you say, it's not meant for importing, but the source code is meant for reading by end users of python. When you run the demos, the source code is displayed alongside the animation. So I think that the value of the stubs is the same: a user can read them alongside the source of the demos, if they're so inclined. On the hand, the primary type of user who would benefit from examining the source code of the demos is less likely to know about typeshed.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants