Enable Ruff PLC (Pylint Convention) #13306
Conversation
lib/ts_utils/utils.py
Outdated
| @@ -14,7 +14,7 @@ | |||
| from packaging.requirements import Requirement | |||
|
|
|||
| try: | |||
| from termcolor import colored as colored # pyright: ignore[reportAssignmentType] | |||
| from termcolor import colored as colored # pyright: ignore[reportAssignmentType] # noqa: PLC0414 | |||
There was a problem hiding this comment.
We should probably just disable this rule, I don't think it's that helpful in typed code where "import X as X" is meaningful.
There was a problem hiding this comment.
Some context: This rule is disabled in *.pyi files (astral-sh/ruff#3761) and there's talks of disabling it out of the box for __init__.py (or it can be easily configured to do so astral-sh/ruff#6294 (comment)).
So it only flags possible accidental re-exports from non-index/init runtime modules.
That being said, we're not a (public) library either (technically ts_utils this is a local lib), and I believe typeshed maintainers should be able to quickly spot an involuntary reexports in non-stubs files.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Ref #13295
https://docs.astral.sh/ruff/rules/#convention-c
The only stub changes are flagged by type-name-incorrect-variance (PLC0105), which enforces the
_co/_contrasuffix. Which we didn't consistently do. Even sometimes incorrectly suffixed.import-private-name (PLC2701) is still in preview, so we're not affected yet, but typeshed uses many private imports in its stubs to reference types accurately. I don't think this rule applies to our stubs.
It's unclear whether Ruff should consider disabling it for stubs entirely, but it's mentioned here: astral-sh/ruff#14535