Fix third party scheduled tests running on forks (#525)

* Fix third party scheduled tests running on forks * Refactor repeated condition to predicate job
python · Dec 22, 2024 · 15d48b2 · 15d48b2
1 parent 1ee20f7
commit 15d48b2
Showing 1 changed file with 18 additions and 70 deletions.
diff --git a/.github/workflows/third_party.yml b/.github/workflows/third_party.yml
@@ -26,18 +26,20 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  skip-schedule-on-fork:
+    name: Check for schedule trigger on fork
+    runs-on: ubuntu-latest
+    # if 'schedule' was the trigger,
+    # don't run it on contributors' forks
+    if: >-
+      github.repository == 'python/typing_extensions'
+      || github.event_name != 'schedule'
+    steps:
+      - run: true
+
   pydantic:
     name: pydantic tests
-    if: >-
-      # if 'schedule' was the trigger,
-      # don't run it on contributors' forks
-      ${{
-        github.event_name != 'schedule'
-        || (
-          github.repository == 'python/typing_extensions'
-          && github.event_name == 'schedule'
-        )
-      }}
+    needs: skip-schedule-on-fork
     strategy:
       fail-fast: false
       matrix:
@@ -72,16 +74,7 @@ jobs:
 
   typing_inspect:
     name: typing_inspect tests
-    if: >-
-      # if 'schedule' was the trigger,
-      # don't run it on contributors' forks
-      ${{
-        github.event_name != 'schedule'
-        || (
-          github.repository == 'python/typing_extensions'
-          && github.event_name == 'schedule'
-        )
-      }}
+    needs: skip-schedule-on-fork
     strategy:
       fail-fast: false
       matrix:
@@ -117,16 +110,7 @@ jobs:
 
   pyanalyze:
     name: pyanalyze tests
-    if: >-
-      # if 'schedule' was the trigger,
-      # don't run it on contributors' forks
-      ${{
-        github.event_name != 'schedule'
-        || (
-          github.repository == 'python/typing_extensions'
-          && github.event_name == 'schedule'
-        )
-      }}
+    needs: skip-schedule-on-fork
     strategy:
       fail-fast: false
       matrix:
@@ -163,16 +147,7 @@ jobs:
 
   typeguard:
     name: typeguard tests
-    if: >-
-      # if 'schedule' was the trigger,
-      # don't run it on contributors' forks
-      ${{
-        github.event_name != 'schedule'
-        || (
-          github.repository == 'python/typing_extensions'
-          && github.event_name == 'schedule'
-        )
-      }}
+    needs: skip-schedule-on-fork
     strategy:
       fail-fast: false
       matrix:
@@ -210,16 +185,7 @@ jobs:
 
   typed-argument-parser:
     name: typed-argument-parser tests
-    if: >-
-      # if 'schedule' was the trigger,
-      # don't run it on contributors' forks
-      ${{
-        github.event_name != 'schedule'
-        || (
-          github.repository == 'python/typing_extensions'
-          && github.event_name == 'schedule'
-        )
-      }}
+    needs: skip-schedule-on-fork
     strategy:
       fail-fast: false
       matrix:
@@ -262,16 +228,7 @@ jobs:
 
   mypy:
     name: stubtest & mypyc tests
-    if: >-
-      # if 'schedule' was the trigger,
-      # don't run it on contributors' forks
-      ${{
-        github.event_name != 'schedule'
-        || (
-          github.repository == 'python/typing_extensions'
-          && github.event_name == 'schedule'
-        )
-      }}
+    needs: skip-schedule-on-fork
     strategy:
       fail-fast: false
       matrix:
@@ -309,16 +266,7 @@ jobs:
 
   cattrs:
     name: cattrs tests
-    if: >-
-      # if 'schedule' was the trigger,
-      # don't run it on contributors' forks
-      ${{
-        github.event_name != 'schedule'
-        || (
-          github.repository == 'python/typing_extensions'
-          && github.event_name == 'schedule'
-        )
-      }}
+    needs: skip-schedule-on-fork
     strategy:
       fail-fast: false
       matrix: