Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] VIP Integration #487

Merged
merged 4 commits into from
Sep 26, 2022
Merged

[Feature] VIP Integration #487

merged 4 commits into from
Sep 26, 2022

Conversation

JasonMa2016
Copy link
Contributor

Description

  1. VIP model code in torchrl/transforms/vip.py.
  2. Testing code appended to test/test_transforms.py.
  3. Ensured that all tests pass.

Motivation and Context

New pre-trained visual encoder for RL from FAIR.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2022
@JasonMa2016 JasonMa2016 changed the title VIP Integration [Feature] VIP Integration Sep 24, 2022
@vmoens
Copy link
Contributor

vmoens commented Sep 24, 2022

Thanks for this @JasonMa2016, wonderful contribution!
Do we want to design a reward transform while we're at it? Or should this be part of a separate PR?

@vmoens vmoens added the enhancement New feature or request label Sep 25, 2022
@JasonMa2016
Copy link
Contributor Author

Let's make reward transform a separate PR! We can discuss what's the best way to go about this.

@vmoens vmoens merged commit 592eed5 into pytorch:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants