Do not set all reference type schemas as nullable=true, see also #3

qaware · Nov 30, 2020 · 9c4216c · 9c4216c
1 parent 3c29e49
commit 9c4216c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/...orforspring/common/schema/resolver/type/initial/InitialSchemaBuilderForReferenceType.java b/...orforspring/common/schema/resolver/type/initial/InitialSchemaBuilderForReferenceType.java
@@ -34,12 +34,7 @@ public class InitialSchemaBuilderForReferenceType implements InitialSchemaBuilde
     public InitialSchema buildFromType(JavaType javaType, AnnotationsSupplier annotationsSupplier, Resolver resolver) {
         if (javaType.isReferenceType()) {
             // TODO append annotationSupplier with contained generic type!
-            InitialSchema initialSchema = resolver.resolveFromType(javaType.getContentType(), annotationsSupplier);
-            if (initialSchema != null && initialSchema.getSchema().getNullable() == null) {
-                // TODO check if all jackson reference types should be considered @Nullable by default
-                initialSchema.getSchema().setNullable(true);
-            }
-            return initialSchema;
+            return resolver.resolveFromType(javaType.getContentType(), annotationsSupplier);
         }
         return null;
     }

diff --git a/openapi-generator-for-spring-test/src/test/resources/openApiJson/app5.json b/openapi-generator-for-spring-test/src/test/resources/openApiJson/app5.json
@@ -54,14 +54,7 @@
         "operationId": "getMappingWithOptionalString",
         "responses": {
           "200": {
-            "description": "Default response",
-            "content": {
-              "*/*": {
-                "schema": {
-                  "$ref": "#/components/schemas/nullable_string"
-                }
-              }
-            }
+            "$ref": "#/components/responses/200"
           }
         }
       }