Skip to content

Commit

Permalink
Replace TODO with GH Issue #8
Browse files Browse the repository at this point in the history
  • Loading branch information
neiser committed Nov 30, 2020
1 parent e195a42 commit be3e74f
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void customize(Operation operation, OperationBuilderContext operationBuil
// this customizer explicitly overrides already present parameters built from the operation annotation,
// as the order of parameters is important and should not be determined
// by the order of information to build those parameters!
// TODO maybe consider making the above choice about parameter ordering better bean-customizable?
// See GH issue #8
List<Parameter> parameters = buildParameters(operationBuilderContext);
setParametersToOperation(operation, parameters, operationBuilderContext);
}
Expand Down Expand Up @@ -120,7 +120,6 @@ private List<Parameter> buildParameters(OperationBuilderContext operationBuilder
return preferRequiredParameters(parameters);
}

// TODO make this sorting customizable? See also other TODO here
private static List<Parameter> preferRequiredParameters(List<Parameter> parameters) {
Map<Boolean, List<Parameter>> partitionedParameters = parameters.stream()
.collect(Collectors.partitioningBy(p -> Boolean.TRUE.equals(p.getRequired())));
Expand Down

0 comments on commit be3e74f

Please sign in to comment.