Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about new symbol used in Unofficial-search-plugins.mediawiki #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flyxyz123
Copy link

@flyxyz123 flyxyz123 commented Dec 30, 2024

Tokyo Toshokan used new symbol ❌ to show it breaks qbt plugin system as shown in here. However, it is not documented in the "Read First" section.

Tokyo Toshokan used new symbol ❌ to show it breaks qbt plugin system.
However, it is not documented in the "Read First" section.
@flyxyz123
Copy link
Author

flyxyz123 commented Dec 30, 2024

Another maybe better way is to change symbol ❌ to symbol ✖ in Tokyo Toshokan's section. I noticed this because the new symbol ❌ breaks my old script that auto download good unofficial search plugins and update every month. This use of new symbol caused my script to download bad tokyotoshokan.py which breaks my search plugin system for three months, and I was only able to fix it after spending hours until I saw that Tokyo Toshokan may break search plugin system, so I removed tokyotoshokan.py and it worked.

But I do understand that red ❌ can get more attention than grey ✖. And the tokyotoshokan.py issue is very serious, so the use of ❌ is a good fit here. Thus my pull request is to add documentation about ❌ instead of replace ❌ with ✖.

@thalieht
Copy link

Another maybe better way is to change symbol ❌ to symbol ✖ in Tokyo Toshokan's section.

IMO either this or change all ✖ to ❌. Having 2 X is pointless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants