Ntp fix #48
Closed
Ntp fix #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jstucke
commented
Jan 17, 2024
jstucke
commented
- fixed struct error in ntp_server
…into proxy-dummy-response
Proxy dummy response
Refactoring 2
Refactoring 3
refactoring of main file and bug fix
reenable logging and warnings
ntp_server bug fix
|
Sorry, I accidentally opened this PR on the wrong branch. I will open more reasonable, smaller PRs for the bug fixes instead. |
|
What is more, there were some changes to make fixing stuff easier (like re-formatting everything with black/ruff, adding unit tests. adding a .gitignore, adding pre-commit, enabling logging of errors and warnings, removing the clean-up action, etc.) and I don't know if you even want to merge all of them 😅 Would you prefer a PR with only the bug fixes or would you like to add some of the other changes as well? |
|
@jstucke no problem, if you do smaller PRs, I will merge all of them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.