Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pre-commit #50

Merged
merged 19 commits into from
Jan 22, 2024
Merged

added pre-commit #50

merged 19 commits into from
Jan 22, 2024

Conversation

jstucke
Copy link
Contributor

@jstucke jstucke commented Jan 22, 2024

  • replaced "qb" github action with pre-commit
    • added pre-commit config with ruff and ruff format
  • converted setup.py to modern pyproject.toml format
    • added ruff config to pyproject.toml
    • updated auto-pip.sh script (caution: the build package must be installed)

future work: Add a GitHub action that runs pre-commit (there are still many issues in the code that need fixing first)

@jstucke
Copy link
Contributor Author

jstucke commented Jan 22, 2024

The tests are a bit flaky on the slower GitHub action workers but should get fixed later down the line (in 5833277 to be precise)

@giga-a giga-a merged commit 73f4c3a into qeeqbox:main Jan 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants