Fix transpilation error on windows when using AQT primitives #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airwoodix
force-pushed
the
ci-windows
branch
4 times, most recently
from
b45a68e to
3fe41e3
Compare
airwoodix
force-pushed
the
ci-windows
branch
2 times, most recently
from
0939966 to
ea17708
Compare
airwoodix
force-pushed
the
ci-windows
branch
2 times, most recently
from
8d546ea to
d8163c5
Compare
This reverts commit 8d19d82.
wilfried-huss
approved these changes
Jan 24, 2024
Closed
fg-aqt
approved these changes
Jan 24, 2024
airwoodix
changed the title
|
Upstream patch: Qiskit/qiskit#11637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix transpilation errors happening on Windows where the transpiler seemingly isn't applied when using the specialized AQT primitives.
Details and comments
The root error comes from the use of
fnmatchin theDecomposetranspilation pass, applied in the bound pass manager in the AQT primitives.fnmatch, is case-sensitive on Linux but case-insensitive on Windows, which leads to wrong decomposition of the substitutedrxxoperations after theWrapRxxAnglespass.To confirm the fix, run the examples on Windows on CI. A follow-up PR will try to run more of the testing suite.
Fixes #121.