Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with default black line length #45

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

garrison
Copy link
Member

Summary

Black uses a line length of 88 by default, so this updates CONTRIBUTING.md accordingly. Alternatively, we could use a line length of 100; in this case, we would have to pass it as an argument to black in tox.ini.

Details and comments

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2067414667

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2067351188: 0.0%
Covered Lines: 11
Relevant Lines: 11

💛 - Coveralls

@caleb-johnson
Copy link
Collaborator

Summary

we could use a line length of 100

Details and comments

Do you have an opinion on it?

@garrison
Copy link
Member Author

I don't have a strong opinion, but I think there is a good case for 100. The applications modules seem to use that as the limit, set in each repository's pyproject.toml. (This probably makes more sense than doing it in tox.ini, as I suggested in the top post.)

@garrison
Copy link
Member Author

I'm going to merge this, since our goal is to keep the template repository in a near-perfect state at all times. I'll add the commit that reverts this change to #46, so that everything will be consistent then too if we decide to change the line length to 100 and merge it.

@garrison garrison merged commit 8b08a62 into main Apr 12, 2022
@garrison garrison deleted the black-default-line-length branch April 12, 2022 11:11
garrison added a commit that referenced this pull request Apr 12, 2022
@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 2067414667

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2067351188: 0.0%
Covered Lines: 11
Relevant Lines: 11

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants