-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shuguet shu89 split keyboard (PCB + Case are open-source) #24758
Open
shuguet
wants to merge
23
commits into
qmk:master
Choose a base branch
from
shuguet:shuguet-shu89
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+362
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest
Fast-forward to current version
…are into shuguet-split89_rp2040
…are into shuguet-split89_rp2040
…are into shuguet-split89_rp2040
waffle87
requested changes
Dec 29, 2024
Thank you for the review @waffle87 , I've updated almost all asks, just waiting on more context surrounding lighting and VIA and how to make a purely config/data-driven keyboard like mine (without a |
4 tasks
Hum?
|
drashna
requested changes
Dec 30, 2024
zvecr
requested changes
Dec 31, 2024
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding on keyboard and it's associated keymap.
This is an 89 keys split keyboard, made up of a single (breakable) PCB + a case (can be either 3D printed or CNC made).
Both case and PCBs are done, only the CNC technical drawings are left TODO.
Types of Changes
Issues Fixed or Closed by This PR
Checklist